[BUGFIX] Fix siteLanguage("locale") TypoScript condition example
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests should run after rebasing, failures where not related to this PR |
|
I synced the changes from upstream to my fork in Github. |
froemken
approved these changes
Jan 4, 2025
|
Hello @cundd I have tested that behavior. In TYPO3 core I found a Charset normalizer which converts all underscores to dashes. Thank you for your patch. I have just merged it. Stefan |
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-1449-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 9f106d7d3f357d646d26891c97834cb174178b10,4dfbc334b71bfcc5fa90f5ea014cad08cb23a21d
# Push it to GitHub
git push --set-upstream origin backport-1449-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4Then, create a pull request where the |
froemken
pushed a commit
that referenced
this pull request
Jan 4, 2025
froemken
added a commit
that referenced
this pull request
Jan 4, 2025
…1449) (#1502) Co-authored-by: Daniel Corn <[email protected]>
froemken
added
backport-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example for the
siteLanguagecondition does not seem to be working. If I understand the code correctly, the locale string will be normalized to use dashes (e.g.fr-CH) as separator instead of an underscore (fr_CH) (see Locale.php.The output of "locale" in
<f:debug>{siteLanguage}</f:debug>is also a bit misleading as it uses theposixFormattedversion instead of the one used in the TypoScript condition.Please check this proposed change carefully, as I may not understand the whole picture and/or some things depend on the actual hosting environment.
Successor of PR #1436